feat(ui): privacy-toestemming vóór upload + confidence-bewuste 'pas alle toe' (#23, #48)#52
Merged
Merged
Conversation
…lle toe' Databron-UI (datasource.py): - #23: verplichte toestemmings-checkbox vóór upload; uploader disabled tot bevestigd. st.info over lokale verwerking + popover 'wat telt als persoonsgegevens'. - #48: 'pas alle aanbevelingen toe' past alleen zekere suggesties (>=90%) toe; onzekere (<90%) worden gemarkeerd en altijd handmatig bevestigd. Closes #23 Closes #48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wat
Golf 1, PR 1 van het UX-traject. Twee quick wins in de databron-UI (
src/edu_synth/ui/datasource.py).#23 — Privacy-toestemming vóór upload
st.info()over lokale verwerking i.p.v. de passieve caption.disabledtot de gebruiker bevestigt (beperking verslaat instructie).#48 — "Pas alle aanbevelingen toe" respecteert confidence
_HIGH_CONFIDENCE; splitsing in testbare helperpartition_by_confidence.Tests
partition_by_confidence(drempel, inclusiviteit, alles-onzeker).ruff check+ruff formatschoon.Opmerkingen
ui-designer-skill bewust niet gedraaid: dit zijn kleine tweaks (scope schalen naar waarde). Principes wel toegepast.Closes #23
Closes #48