feat(ui): overall oordeel-banner vóór de tabs + waarschuwing bij hoog risico (#18)#54
Merged
Merged
Conversation
… risico results.py (#18): - Gekleurde oordeel-banner (groen/oranje/rood) vóór de tabs met overall bruikbaarheidsoordeel + usage_recommendation, zodat ook wie direct naar Download gaat het oordeel ziet. - Dubbele verdict-tekst uit de validatie-tab gehaald (banner draagt 'm nu); scorecards blijven als breakdown. Dode 'recommendation'-parameter verwijderd. - Inline foutmelding bij de downloadknop wanneer het oordeel 'hoog' risico is. Closes #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wat
Golf 2 van het UX-traject. Het overall validatieoordeel zat verstopt in tab 1; wie direct naar Download klikte miste het. (
src/edu_synth/ui/results.py)#18 — Overall oordeel vóór de tabs
usage_recommendation-zin. Altijd zichtbaar, ongeacht welk tabblad open is.recommendation-parameter uit_render_validationverwijderd;_VERDICT_TEXTnaar module-niveau.Tests
_bruikbaarheid_verdict(bepaalt de bannerkleur): hoog/matig/laag-paden.ruff check+formatschoon.Docs
docs/aan-de-slag.mdstap 4: oordeel-banner + waarschuwing beschreven.Opmerkingen
ui-designer-skill bewust niet gedraaid: kleine/mid tweak op bestaande flow (scope schalen naar waarde). Wel de onderliggende UX-principes toegepast (Peak-End: oordeel als laatste indruk vóór download; visuele hiërarchie via gekleurd blok).Closes #18