feat(backend-sep38): [sep-38] update quotes cache expiration rules#664
Open
GideonBature wants to merge 1 commit into
Open
feat(backend-sep38): [sep-38] update quotes cache expiration rules#664GideonBature wants to merge 1 commit into
GideonBature wants to merge 1 commit into
Conversation
|
@GideonBature Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sep38-quotes-cache.config.tswith validation that cache TTLs cannot outlive indicative quote expiration.SEP38_*environment variables for indicative quote expiration, firm quote validity, cache TTL, stale TTL, and assets cache TTL.Sep38Controllerto use the shared config and reject cached quotes whoseexpiration_timehas passed, refetching fresh prices instead.Changes
sep38-quotes-cache.config.tsvalidateSep38QuotesCacheConfig(),isQuoteExpired(), andbuildQuoteExpirationTime()env.tsSEP38_*env vars with per-field bounds and cross-field validation at startupsep38.controller.ts.env.exampleTest plan
npx jest src/config/sep38-quotes-cache.config.test.ts— validation rules and expiration helpersnpx jest src/api/controllers/sep38.controller.test.ts— quote calculation and expiration behaviornpm run test:backend— full backend suite (note: unrelated pre-existing failures in multisig/sep31 tests)expiration_timematchesSEP38_INDICATIVE_QUOTE_EXPIRATION_SECONDSexpiresAtmatchesSEP38_FIRM_QUOTE_VALIDITY_SECONDSCloses #620