feat: STORAGE_PROVIDER:#697
Merged
Merged
Conversation
|
@ONEONUORA Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@ONEONUORA , LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #546
close #567
close #558
close #534
Description
This PR implements four tasks across the backend services and smart contracts to improve startup robustness, governance security, KycCustomer data access performance, and pending file lifecycle cleanup.
Proposed Changes
1. Validate
STORAGE_PROVIDERConfiguration at StartupSTORAGE_PROVIDERenvironment variable matchess3orgcsand validates all necessary sub-config keys (buckets and credentials).backend/src/index.ts. If invalid, the process logs an error and exits with code1.2. Governance Smart Contract: Admin Transfer & Env Fixes
transfer_admin) endpoint verifying caller authorization viarequire_auth().Admininside the contract instance storage.calculate_quorumhelper usingu128math for high supply inputs.stdmacros, staticEnvconstants, and SDK version mismatches) by introducing a dynamic thread-local context matching Soroban SDK v22+ requirements.3. Expiration Job for Stale Uploads
upload-expiry.scheduler.tsusingnode-cronscheduled to execute every minute.PENDINGKycCustomer uploads that exceed their expiration timestamp and marks them asEXPIRED.4. Database Indexing for
KycCustomerTable@@index([status])) on thestatusfield inbackend/prisma/schema.prismato optimize lookup times.backend/prisma/migrations/directory.Verification & Test Status
Backend Tests (Jest)
769 passedacross all 73 active test suites.Smart Contract Tests (Cargo)