Skip to content

Add BIH metadata to output model #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethrj merged 1 commit into from
Feb 9, 2026
Merged

Add BIH metadata to output model #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions celerpy/model/output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,15 @@ class BihSizes(_Model):
local_volume_ids: NonNegativeInt


# orange/OrangeParamsOutput.hh
class BihMetadata(_Model):
"""Bounding Interval Hierarchy characteristics."""

num_finite_bboxes: list[NonNegativeInt]
num_infinite_bboxes: list[NonNegativeInt]
depth: list[NonNegativeInt]
Comment on lines +76 to +81
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New BihMetadata and the new OrangeParamsOutput.bih_metadata field aren’t covered by the existing model-parsing tests. Please add a unit test that validates JSON parsing for BihMetadata (and ideally OrangeParamsOutput including the bih_metadata key) to prevent schema regressions.

Copilot uses AI. Check for mistakes.


# orange/OrangeParamsOutput.hh
class UniverseIndexerSizes(_Model):
"""Universe indexer sizes."""
Expand Down Expand Up @@ -115,6 +124,7 @@ class OrangeParamsOutput(_Model):
_label: Literal["orange"]
scalars: OrangeScalars
sizes: OrangeSizes
bih_metadata: BihMetadata
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OrangeParamsOutput docstring says it contains only “sizes and scalars”, but this PR adds bih_metadata. Update the docstring to reflect the additional output content so it stays accurate for API consumers.

Copilot uses AI. Check for mistakes.


class ExceptionDump(_Model):
Expand Down
Loading