Remove conditional skip from production deploy workflow#75
Merged
Conversation
The `if: secrets.X != ''` job-level conditional in deploy-prod.yml was
rejected by GitHub Actions at parse time ("Unrecognized named-value:
'secrets'"), so every run since the workflow landed failed before
reaching any step. The `secrets` context is only available inside
steps (`steps[*].if`, `steps[*].env`, etc.), not at the job-level
`if:`.
The gate was intended for first-time setup; setup is now complete, so
the simplest fix is to remove it. If the key is rotated/missing, the
deploy step will fail loudly on the SSH push, which is the right
behavior.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the conditional check that was silently skipping the production deployment workflow when the deploy key secret was not configured. This allows the workflow to proceed regardless of whether the deployment credentials have been set up.
Changes
ifcondition that checked forsecrets.CELESTIARY_GITHUB_IO_DEPLOY_KEYbefore running the deploy jobNotes
This change means the workflow will no longer silently skip on first-time setup when the deploy key hasn't been configured. Subsequent steps in the workflow will need to handle missing credentials appropriately, or the deploy key should be configured before this workflow is triggered.
https://claude.ai/code/session_01KJ3SXjNcUjMC8atyxnWfDd