Added tests for Reel::Request#227
Conversation
| client << ExampleRequest.new.to_s | ||
| c = connection.detach | ||
|
|
||
| expect(c).to be_a Reel::Connection |
There was a problem hiding this comment.
@digitalextremist Do you we can combine line 345 with this line?
There was a problem hiding this comment.
Yes @aayushranaut, you can move connection.detach into the expect() call.
There was a problem hiding this comment.
@digitalextremist Moved connection.detach into expect() call.
|
Code base coverage increased from 91.35% to 91.78% covered. |
|
@digitalextremist check for merging |
| client << ExampleRequest.new.to_s | ||
| request = connection.request | ||
|
|
||
| expect(request.inspect).to eq '#<Reel::Request GET / HTTP/1.1 @headers={"Host"=>"www.example.com", "Connection"=>"keep-alive", "User-Agent"=>"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_3) AppleWebKit/535.11 (KHTML, like Gecko) Chrome/17.0.963.78 S", "Accept"=>"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8", "Accept-Encoding"=>"gzip,deflate,sdch", "Accept-Language"=>"en-US,en;q=0.8", "Accept-Charset"=>"ISO-8859-1,utf-8;q=0.7,*;q=0.3"}>' |
There was a problem hiding this comment.
I would pull this user agent especially from a constant @prathmeshranaut. It seems like a good idea to move the ExampleRequest initialization values into a constant, then use the constant in initialize there -- but then also use the constant here in the test. This is a lot of hard-coded ultra-specific information :)
|
Once you make the change I mentioned, this is good to pull. Great work @prathmeshranaut |
|
@digitalextremist Please take a look. |
| (@body ? @body : '') | ||
| end | ||
|
|
||
| def inspect_method |
There was a problem hiding this comment.
I think I could do better with naming this stub. Do you have any suggestions?
2 participants
Added two new tests for Reel::Request class.
@digitalextremist Please check the correct context of the test comment if better position for the tests can be provided.
Code base coverage increased from 91.35% to 91.57% covered.
Coverage for
lib/reel/request.rbincreased from 97.01% to 100%