Add PR review notes; hardlink detection and changelog stdio fixes#2
Closed
cenglin123 wants to merge 1 commit into
Closed
Add PR review notes; hardlink detection and changelog stdio fixes#2cenglin123 wants to merge 1 commit into
cenglin123 wants to merge 1 commit into
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
cenglin123
added a commit
that referenced
this pull request
Jun 23, 2026
Adds a 'docs/ 文件的治理规则' subsection to AGENTS.md template, defining existence conditions, merge conditions, creation principles, deletion principles, and a self-exemption clause. Uses Occam + Bitter Lesson as general engineering judgment criteria — no enumerated thresholds (per ultraverge finding). Changes: - AGENTS.md.tpl: new governance rules subsection (between 定期审计 and 完工检查清单) - STRUCTURE.md.tpl: governance pointer comment at top - 9 templates: single-line pointer to AGENTS.md governance rules - SKILL.md: philosophy #2, step 2, step 7 static check updated - Plan archived to docs/plans/completed/ Ultraverge (3 reviewers) → converge R2 → blind recheck pass Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR_REVIEW.mdnote to clarify commit/merge process and recommended checks.Description
PR_REVIEW.mdwith guidance about the PR status, maintainer clarification, and recommended CI checks.assets/scripts/agent_links.pyto makeis_hardlink_group()return false unless all link keys are present and each file hasst_nlink > 1, and to handleOSErrorwhen readingstat.assets/scripts/changelog.pyby addingconfigure_stdio()andemit()helpers, replacing directprint()calls withemit()to safely write UTF-8 output, and callingconfigure_stdio()frommain().Testing
pytestand any CI pre-commit hooks before merging.Codex Task