Skip to content

feat(map): allow meta services in metric links and gauges#240

Merged
vuntz merged 10 commits into
devfrom
MON-174548-map-metaservice-link
May 6, 2026
Merged

feat(map): allow meta services in metric links and gauges#240
vuntz merged 10 commits into
devfrom
MON-174548-map-metaservice-link

Conversation

@gfontaineCentreon
Copy link
Copy Markdown

@gfontaineCentreon gfontaineCentreon commented Apr 20, 2026

Description

JIRA

  • Add resource2Id and resource2Name to linkProps so that metric link properties are correctly read and written when the shape wizard is opened.
  • Store a reference to the edited cell (graph._centreonEditCell) before posting the setShowWizardShapeProperties message, and use it as a fallback in the setDataProperties handler. This fixes a case where getSelectionCell() returns null because the iframe hosting the wizard steals focus from the graph, causing the property update to be silently dropped.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 24.04.x
  • 24.10.x
  • 25.10.x
  • develop

How this pull request can be tested ?

  • Open a metric link shape, edit its properties in the wizard — verify resource2Id and resource2Name are saved correctly. - Confirm that clicking inside the wizard panel (triggering an iframe focus change) does not prevent the properties from being applied when the wizard is submitted.

Summary by Aikido

Security Issues: 0 Quality Issues: 0 Resolved Issues: 0

🚀 New Features

  • Allowed meta services in metric links and gauges by adding resource2Id/resource2Name properties

⚡ Enhancements

  • Updated minified JavaScript assets and merged related changes across files

🐛 Bugfixes

  • Applied fallback to use stored edit cell when wizard stole focus

More info

@gfontaineCentreon gfontaineCentreon requested a review from a team as a code owner April 20, 2026 09:14
@gfontaineCentreon gfontaineCentreon changed the title Mon 174548 map metaservice link feat(map): allow meta services in metric links and gauges Apr 20, 2026
Comment thread src/main/webapp/js/diagramly/EditorUi.js
Comment thread src/main/webapp/js/diagramly/EditorUi.js
Comment thread src/main/webapp/js/grapheditor/Actions.js Outdated
@gfontaineCentreon gfontaineCentreon requested a review from vuntz April 23, 2026 10:11
Comment thread src/main/webapp/js/diagramly/EditorUi.js
# Conflicts:
#    src/main/webapp/js/app.min.js
#    src/main/webapp/js/stencils.min.js
#    src/main/webapp/js/viewer-static.min.js
#    src/main/webapp/js/viewer.min.js
@vuntz vuntz merged commit da70370 into dev May 6, 2026
4 checks passed
@vuntz vuntz deleted the MON-174548-map-metaservice-link branch May 6, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants