helm: remove csi RBAC from the operator

[Madhu-1]

CSI template and RBAC's are shipped as another charts. we dont need to add the csi RBAC to the operator charts.

[travisn]

What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it?

[Madhu-1]

What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it?

@travisn the CSI RBAC was part of both charts. am removing it from the operator chart so that it will be present only in the csi-driver charts

[travisn]

What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it?

@travisn the CSI RBAC was part of both charts. am removing it from the operator chart so that it will be present only in the csi-driver charts

Rook doesn't currently install the csi-driver chart, only the csi-operator chart. Can this be factored out as a helm library so the rbac can still come with the csi-operator chart?

[Madhu-1]

What chart is the rbac in? Does Rook need to add a helm dependency on it or does the csi operator chart have a dependency on it?

@travisn the CSI RBAC was part of both charts. am removing it from the operator chart so that it will be present only in the csi-driver charts

Rook doesn't currently install the csi-driver chart, only the csi-operator chart. Can this be factored out as a helm library so the rbac can still come with the csi-operator chart?

Having this in csi-operator chart is not a good idea because this are per drivers not for the operator. I need to look into this one and also we need to talk about long term look plan as well, What we have discussed was that Rook will move the CSI to the user management and not to generate(manage) the Csi-operator CR's.

[travisn]

To summarize our discussion:

• In the next minor release of Rook (v1.19), Rook will add a helm dependency on the csi drivers chart.
• This RBAC change will not be made until the CSI operator 1.0 release (which is when Rook v1.19 will consume it)
• Note that csi drivers chart is for creating the csi CRs (and is not related to the old csi drivers chart)

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

[travisn]

not stale

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

[github-actions]

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

[Madhu-1]

@travisn @subhamkrai I am planning to make this changes in csi operator, please switch to csi driver helm charts for Rook in Rook 1.20

[subhamkrai]

@travisn @subhamkrai I am planning to make this changes in csi operator, please switch to csi driver helm charts for Rook in Rook 1.20

@Madhu-1 This means rook will need to have two chart as dependency csi-operator chart and csi-driver chart?

[Madhu-1]

@travisn @subhamkrai I am planning to make this changes in csi operator, please switch to csi driver helm charts for Rook in Rook 1.20

@Madhu-1 This means rook will need to have two chart as dependency csi-operator chart and csi-driver chart?

Yes correct

[travisn]

With the transition of the rbac from one chart to the other, we will need to test the upgrades to ensure a smooth transition. Hopefully the helm upgrade test in Rook will catch any issues, but let's discuss in more detail.

[Madhu-1]

With the transition of the rbac from one chart to the other, we will need to test the upgrades to ensure a smooth transition. Hopefully the helm upgrade test in Rook will catch any issues, but let's discuss in more detail.

Yes correct, If we start the testing early it would be good to see if there are any problem.