check_ceph_osd_db: Decode bytes output to string#85
Open
lbausch wants to merge 1 commit intoceph:masterfrom
Open
check_ceph_osd_db: Decode bytes output to string#85lbausch wants to merge 1 commit intoceph:masterfrom
lbausch wants to merge 1 commit intoceph:masterfrom
Conversation
Avoids `TypeError: cannot use a string pattern on a bytes-like object`
valerytschopp
approved these changes
Jan 9, 2023
|
Noted this issue and it fixed the problem for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids
TypeError: cannot use a string pattern on a bytes-like objectwhen executingre.findall().Popen.communicate()returns bytes if the streams weren't opened in text mode, which is not the case here, as far as I can tell. See https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate