Skip to content

Governance: folks meaningfully contributing to the biweekly can become GitHub Members#11

Draft
maelvls wants to merge 1 commit intomainfrom
governance-update
Draft

Governance: folks meaningfully contributing to the biweekly can become GitHub Members#11
maelvls wants to merge 1 commit intomainfrom
governance-update

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Sep 15, 2023

This is a WIP PR that will need approval from all the maintainers before being merged.

…hub members

Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Sep 15, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maelvls. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2023
@maelvls maelvls requested a review from Copilot November 14, 2025 15:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the cert-manager governance documentation to expand contribution recognition criteria and clarify the maintainer promotion path.

  • Expands the definition of "meaningful interactions" to include GitHub PRs and contributions to biweekly dev meetings
  • Changes the maintainer eligibility requirement from "anyone" to "any existing Approver"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

your request will be reviewed by a cert-manager admin, in accordance with their
SLO.
well as links to the meaningful interactions (Slack threads, GitHub issues, GitHub
PRs, or a contribution to one of the biweekly dev meetings). Ask your sponsors
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "a contribution to one of the biweekly dev meetings" is grammatically awkward. Consider rephrasing to either "contributions to the biweekly dev meetings" (plural) or "a contribution to a biweekly dev meeting" (singular with indefinite article) for better clarity.

Suggested change
PRs, or a contribution to one of the biweekly dev meetings). Ask your sponsors
PRs, or contributions to the biweekly dev meetings). Ask your sponsors

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants