Skip to content
Merged

2.0.2 #230

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/actions/push_on_ecr/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ inputs:
image_tag:
description: Directory that must be run against the linters
required: true
image_target:
description: Image target stage
required: true
default: BASE

aws_region:
description: Aws region
Expand All @@ -46,11 +50,12 @@ runs:
uses: docker/setup-buildx-action@v3

- name: Build and push
uses: docker/build-push-action@v5
uses: docker/build-push-action@v6
with:
context: ${{ inputs.working_directory }}
push: true
cache-from: type=gha
cache-to: type=gha,mode=max
tags: ${{inputs.aws_account_id}}.dkr.ecr.${{inputs.aws_region}}.amazonaws.com/${{ inputs.repository }}:${{ inputs.image_tag }}
file: ${{ inputs.working_directory }}/${{ inputs.dockerfile }}
target: ${{ inputs.image_target }}
2 changes: 1 addition & 1 deletion .github/configurations/node_linters/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ and add these scripts to `package.json`:
"lint-fix": "npm run lint -- --fix",
"lint-scss": "stylelint --config $npm_package_config_stylelint '**/*.{css,scss}'",
"lint-scss-fix": "npm run lint-scss -- --fix",
"formatter": "prettier --config $npm_package_config_prettier . --check",
"formatter": "prettier --config $npm_package_config_prettier --check",
"formatter-fix": "npm run formatter -- --write"
},
```
Expand Down
90 changes: 73 additions & 17 deletions .github/configurations/node_linters/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -1,36 +1,92 @@
/*
import js from '@eslint/js';
import pluginJest from 'eslint-plugin-jest';
import globals from 'globals';
import { defineConfig, globalIgnores } from 'eslint/config';
import nextVitals from 'eslint-config-next/core-web-vitals';
*/
// Need require relative to the cwd
// Need inport relative to the cwd
import path from 'path';
import { createRequire } from 'module';
const requireFromCwd = createRequire(path.resolve(process.cwd(), 'package.json'));
const { defineConfig, globalIgnores } = requireFromCwd('eslint/config');
const { FlatCompat } = requireFromCwd('@eslint/eslintrc');
const js = requireFromCwd('@eslint/js');
const jsdoc = requireFromCwd('eslint-plugin-jsdoc');
const pluginJest = requireFromCwd('eslint-plugin-jest');
// const importPlugin = requireFromCwd('eslint-plugin-import');
const globals = requireFromCwd('globals');
const nextVitals = requireFromCwd('eslint-config-next/core-web-vitals');

// eslint-plugin-import
const compat = new FlatCompat({
baseDirectory: import.meta.dirname,
resolvePluginsRelativeTo: process.cwd()
});
const eslintImport = [
...compat.config({
extends: ['plugin:import/recommended'],
settings: {
'import/resolver': {
next: true,
},
},
}),
];

export default defineConfig([
globalIgnores(['node_modules/**', '.next/**', 'out/**', 'build/**', 'next-env.d.ts', 'public/sw.js']),
globalIgnores([
'node_modules/**',
'.next/**',
'out/**',
'build/**',
'next-env.d.ts',
'public/sw.js',
'.vscode/**',
'.github/**',
]),
...nextVitals.map((config) => ({
...config,
files: ['app/**/*.{js,mjs,cjs,jsx}'], // Specific for next app
})),
files: ['{app,tests}/**/*.{js,mjs,cjs,jsx}'], // Specific for next app
})),
...eslintImport, // BUG in flat config importPlugin.flatConfigs.recommended (https://github.com/import-js/eslint-plugin-import/issues/3212)
{
files: ['**/*.{js,mjs,cjs,jsx}'], // For all files
plugins: { js },
extends: ['js/recommended'],
languageOptions: { globals: globals.node },
}, {
files: ['**/*.spec.js', '**/*.test.js'],
plugins: { js, jsdoc },
extends: ['js/recommended', 'jsdoc/flat/recommended'],
languageOptions: { globals: { ...globals.node, ...globals.browser } },
rules: {
'prefer-destructuring': [
'error',
{
object: true,
array: false,
},
],
'no-console': [
'error',
{
allow: ['warn', 'error'],
},
],
'no-unused-vars': [
'error',
{
varsIgnorePattern: '^_',
argsIgnorePattern: '^_',
args: 'after-used',
},
],
'no-underscore-dangle': [
'error',
{
allowAfterThis: true,
},
],
'jsdoc/require-jsdoc': 0,
'jsdoc/reject-any-type': 0,
'jsdoc/reject-function-type': 0,
},
},
{
files: ['tests/**/*.{js,mjs,cjs,jsx}', '**/*.spec.js', '**/*.test.js'],
plugins: { jest: pluginJest },
extends: ['jest/recommended'],
languageOptions: {
globals: pluginJest.environments.globals.globals,
},
},
]);
]);
4 changes: 4 additions & 0 deletions .github/configurations/node_linters/packages-linters.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,9 @@ eslint
@eslint/js
eslint-config-next
eslint-plugin-jest
eslint-plugin-import
eslint-import-resolver-next
eslint-import-resolver-typescript
eslint-plugin-jsdoc
stylelint
stylelint-config-standard-scss
Loading
Loading