fix: support multiple values for list fields in setup_config command#502
Closed
srijan2607 wants to merge 4 commits intocertego:developfrom
Closed
fix: support multiple values for list fields in setup_config command#502srijan2607 wants to merge 4 commits intocertego:developfrom
srijan2607 wants to merge 4 commits intocertego:developfrom
Conversation
Contributor
Author
|
@Lorygold can you take a look |
Contributor
Could you please add some tests in the |
Contributor
Author
|
@Lorygold take a look |
Contributor
Author
|
@Lorygold can you please update this |
Lorygold
reviewed
Dec 27, 2025
buffalogs/impossible_travel/management/commands/setup_config.py
Outdated
Show resolved
Hide resolved
Contributor
|
@srijan2607 please check if the doc of this command has to be updated, with the correct possible command string here (without AI, please) |
Contributor
|
@srijan2607 could you please update the doc related to this django command? |
Contributor
|
@srijan2607 it seems to not work: Returns: |
Contributor
|
@lucaCigarini @eugenioseveri this can be closed Already solved by the PR #562 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the parsing logic for list values in the
setup_configmanagement command, making it more robust and user-friendly when handling complex list inputs. The main improvements are the introduction of a dedicated parser for comma-separated lists with support for quoted strings, and clearer documentation/examples for end users.Parsing and Input Handling Improvements:
_parse_list_valuesfunction that accurately parses comma-separated list values, supporting single-quoted, double-quoted, and unquoted items, and gracefully handling values with spaces or mixed quoting styles.parse_field_valueto use_parse_list_valuesfor list fields, ensuring consistent and correct parsing of complex list inputs.Documentation and Usability:
create_parserdocstring, demonstrating how to override, append, or remove multiple values (including those with spaces) from list fields, and emphasizing the need for quoting in such cases.Code Maintenance:
reimport and updated type hints to includeList, preparing the code for the new parsing logic.Related issues : #499