fix: correctly parse multi-value list flags in setup_config#539
fix: correctly parse multi-value list flags in setup_config#539nishantxscooby wants to merge 15 commits intocertego:developfrom
Conversation
|
Hi @Lorygold 👋 This PR is a clean restart for issue #499 with a very narrow scope. The fix replaces naive comma-splitting with Thanks for reviewing :) |
|
Are you sure that it works? I get: Test it locally and add a test in the |
|
Hello, I think you're right, and I've been trying to fix this up lately but seems like am again stuck in the CI checks loop, can you please help me get out of this loop? thankyou :) |
|
You can follow the CONTRIBUTING.md file for linters troubleshooting. Did you run them locally? Which are the results and the linters versions? |
|
Hello, okay - thanks for the guidance. I'll look into it as soon as possible, am out for next 3-4 days. Sorry for the inconvenience. |
f220ad9 to
ae323c3
Compare
a8bc9e5 to
a8efea6
Compare
a8efea6 to
c48c707
Compare
|
@nishantxscooby please close this PR, since you opened another one. for next times, work on the same PR, it's not necessary to open a new one, changes can be done in the original one |
|
Hey! @Lorygold Sure, I'll keep that in mind, sorry for the chaos. Also please assign with some issue which are available at moment. Thankyou :) |
Fixes #499
Fix multi-value flag parsing in setup_config
Problem
List values passed via
--append,--override, and--removewere parsed using naive comma splitting, which breaks quoted values with spaces and ISO2 country codes.Solution
Use
ast.literal_evalto safely parse list literals, with a fallback to the previous comma-based logic for backward compatibility.Scope
Testing
Parsing logic was validated directly for: