Skip to content

tests: install pkg-resoures in workflows #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebix merged 1 commit into from
Apr 12, 2026
Merged

tests: install pkg-resoures in workflows #2685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/unittests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Install setuptools for pkg_resources for Python 3.12+, #2569
if: ${{ matrix.python-version >= '3.12' }}

Copilot AI Feb 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition uses string comparison (>=) on matrix.python-version, which is a string value. In GitHub Actions expressions, comparing strings like '3.9' >= '3.12' performs lexicographic comparison, not numeric version comparison. This will incorrectly match Python 3.9 (since '3.9' > '3.12' lexicographically).

Consider using one of these approaches:

  1. Use a list check: if: contains(fromJSON('["3.12", "3.13"]'), matrix.python-version)
  2. Use string equality checks: if: matrix.python-version == '3.12' || matrix.python-version == '3.13'
Suggested change
if: ${{ matrix.python-version >= '3.12' }}
if: ${{ contains(fromJSON('["3.12", "3.13"]'), matrix.python-version) }}

Copilot uses AI. Check for mistakes.

@sebix sebix Apr 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow-up: #2696

run: pip install 'setuptools<82'

- name: Install dependencies for full run
if: ${{ matrix.type == 'full' }}
env:
Expand Down