fix (smtp_batch): CLI overwriting params#2699
Merged
Merged
Conversation
Member
Author
|
(fails have nothing in common with me :) ) |
Member
These failures finally annoyed me enough to implement a permanent solution: #2700 |
sebix
added
component: bots
bug
Member
Author
|
Haha, deal! ;) (In few days) |
sebix
force-pushed
the
fixup-smtp_batch-cli
branch
from
b8de6fc to
cb1afe1
Compare
Member
|
It was a pleasure making a deal with you! |
Member
Author
|
:D <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny fix, argparse made shadow over the defaults. When the user did not specify ex. gpg_key in CLI, the None value overwritten the config file value and no GPG appeared.