Replace pkg_resources usage#2706
Draft
Mirochill wants to merge 2 commits into
Draft
Conversation
Use importlib.resources for bundled configuration and test data paths and importlib.metadata for installed package versions. This removes the runtime dependency on pkg_resources while keeping the existing package data lookup flow centralized in intelmq.lib.utils. The Shodan and url-normalize version checks now use packaging.version.parse instead of tuple splitting, which preserves the existing comparisons and handles normal Python package versions more safely. The temporary CI step that installs old setuptools for certtools#2569 is no longer needed.
Member
|
Thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg_resourcesresource and distribution lookups withimportlib.resourcesandimportlib.metadatahelperspackaging.version.parsefor the existingshodanandurl-normalizeversion checksFixes #2569
Validation
git diff --check HEAD~1..HEADrg -n 'pkg_resources|resource_filename|get_distribution|setuptools<82|setuptools<81' intelmq .github setup.py setup.cfg(no matches)pycodestyleand full unit tests failed02cb7cb55addresses the reportedpycodestylecontinuation indent and theintelmqctltests affected by mockedimportlib.import_module; the new workflow runs are waiting for maintainer approval