Handle missing debugger parameters#2707
Draft
Mirochill wants to merge 1 commit into
Draft
Conversation
When BotDebugger injects a logging level into the runtime configuration, bot entries without a parameters mapping currently raise KeyError or TypeError. Treat missing or null parameters as an empty mapping so the debugger can continue with sparse runtime configs. Add a focused regression test for missing, null, and existing parameters entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2683
Description
BotDebugger.generate_get_runtime()injects the selectedlogging_levelinto every runtime entry before the bot starts. Sparse runtime configs can omitparametersfor a bot, or set it to null, which currently raises before the debugger can continue.This treats missing or null bot parameters as an empty mapping before adding
logging_level, while preserving any existing parameters.Tests
Not run locally.
Remote fork checks passed: