Conversation
johannes-wolf
force-pushed
the
refactor-plot-part-one
branch
from
802122f to
6af8777
Compare
jamesrswift
reviewed
Nov 1, 2024
Collaborator
jamesrswift
left a comment
jamesrswift
left a comment
There was a problem hiding this comment.
Went through the changed ref images to see if there were any regression - I've highlighted those files where I've spotted something, but mostly its some weird behaviour with annotations and marks, and ticks, which are changed.
Collaborator
There was a problem hiding this comment.
Ticks on auto-mirror axes are missing
Collaborator
There was a problem hiding this comment.
Border an mirror axes now present
Collaborator
There was a problem hiding this comment.
Annotations are improperly scaled
Collaborator
There was a problem hiding this comment.
Markers are missing on some series
Collaborator
There was a problem hiding this comment.
Ticks and tick labels missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A more flexible approach of doing plots.
Idea:
add-*-axisin the plot-bodyPlan:
Removing: