Skip to content

Make Raw Context Extendable #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpeabody wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make Raw Context Extendable #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a63aa
Make data members protected so that extending classes have access to …
Apr 13, 2016
0fd4689
pecl/imagick requires PHP >= 5.4.0. Dropping support for 5.3.
Apr 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
language: php

php:
- 5.3
- 5.4
- 5.5
- 5.6
Expand Down
6 changes: 3 additions & 3 deletions src/Cevou/Behat/ScreenshotCompareExtension/Context/RawScreenshotCompareContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

class RawScreenshotCompareContext extends RawMinkContext implements ScreenshotCompareAwareContext
{
private $screenshotCompareConfigurations;
private $screenshotCompareParameters;
protected $screenshotCompareConfigurations;
protected $screenshotCompareParameters;

/**
* {@inheritdoc}
Expand Down Expand Up @@ -93,4 +93,4 @@ public function compareScreenshot($sessionName, $fileName)
throw new \ImagickException(sprintf("Files are not equal. Diff saved to %s", $diffFileName));
}
}
}
}