Honor Enter/Shift+Enter setting consistently#168
Conversation
Removes mobile-specific logic, so the "Send by Shift+Enter" setting now applies equally on mobile and desktop. Enter key behavior in the prompt composer now consistently follows the user preference regardless of device. Updates related tests and removes unused isMobile handling.
cfal
force-pushed
the
main
branch
2 times, most recently
from
a5de8e1 to
5015066
Compare
|
Closing as stale/not needed for now. This branch is dirty against current main, and later mobile composer work intentionally kept mobile Enter as newline/send-button behavior. The broader customizable-hotkeys request remains tracked in #171. |
|
Closing as stale against current main. The current composer shortcut helper intentionally keeps mobile Enter as newline/send-button behavior, and the broader customizable hotkeys work remains tracked in #171. |
|
Reviewed against current main: this PR should stay closed/stale rather than be fixed forward. Main still intentionally passes isMobile into shouldSubmitOnEnter so mobile Enter remains newline/send-button behavior, and the broader customizable-hotkeys request is tracked in #171. I do not have permission to close this PR directly. |
2 participants
This fixes composer submit behavior so the existing
Send by Shift+Entersetting is the single source of truth for keyboard submission.Previously, the shared shortcut helper forced Enter to insert a newline on mobile, regardless of the user setting. That made the setting behave inconsistently across composer surfaces and viewport types.
Changes:
Validation:
bun run checkbun run testtimeout 90s bun run start --port 0