Sign commits and bump create-pull-request to v7 in workflows#322
Merged
Conversation
olehermanse
approved these changes
Jul 2, 2026
SimonThalvorsen
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ole Herman · Slack thread
Summary
Two auto-PR workflows (
update-cfbs-manual,black-format) ran ourcfengine/create-pull-requestfork at v6, which has no commit-signing support. Both now run v7 withsign-commits: true, so the bot-created PR commits are signed.Before:
cfengine/create-pull-request@v6— unsigned bot commits.After:
cfengine/create-pull-request@v7+sign-commits: true— signed bot commits.Notes
v6 → v7is a major bump (v7 runs on Node 20).contents: writepermission — both jobs already grant it.sign-commits: truecombo.Generated by Claude Code