CFE-2780: Fixed warnings from autoreconf#5678
Closed
larsewi wants to merge 13 commits into
Closed
Conversation
larsewi
changed the title
larsewi
force-pushed
the
subdir
branch
3 times, most recently
from
01517a2 to
55421f4
Compare
larsewi
changed the title
larsewi
force-pushed
the
subdir
branch
2 times, most recently
from
79b50e4 to
bcdc9ff
Compare
|
Marking this PR as stale due to inactivity; it will be closed in 7 days. |
|
Closing PR due to inactivity. Feel free to open a new PR if necessary. |
|
|
This way we don't get annoying warnings like: ``` warning: source file '$(srcdir)/../../libutils/statistics.c' is in a subdirectory, but option 'subdir-objects' is disabled ``` Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
``` tests/acceptance/Makefile.am:103: warning: wildcard [0-9]*: non-POSIX variable name tests/acceptance/Makefile.am:103: (probably a GNU make extension) ``` Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Looks like 520144f was an attempt to fix init_script_test_helper from not being cleaned properly. This commit was reverted in ebd97bd, and another attempt was added in 9dc759f. However, the revert actually removed the entire `init_script_test_helper` binary from being compiled. This reapplying the first fix, and combining it with the second fix should do the trick. Found this while trying to clear the warning: ``` tests/unit/Makefile.am:402: warning: variable 'init_script_test_helper_SOURCES' is defined but no program or tests/unit/Makefile.am:402: library has 'init_script_test_helper' as canonical name (possible typo) ``` This reverts commit ebd97bd.
I don't know why, but this was necessary, and all the other tests does this. I was getting the following errors after enabling subdir-objects in `AM_INIT_AUTOMAKE`: ``` Makefile:1843: ../../cf-upgrade/.deps/cf_upgrade_test-alloc-mini.Po: No such file or directory Makefile:1844: ../../cf-upgrade/.deps/cf_upgrade_test-command_line.Po: No such file or directory Makefile:1845: ../../cf-upgrade/.deps/cf_upgrade_test-configuration.Po: No such file or directory Makefile:1846: ../../cf-upgrade/.deps/cf_upgrade_test-log.Po: No such file or directory Makefile:1847: ../../cf-upgrade/.deps/cf_upgrade_test-process.Po: No such file or directory Makefile:1848: ../../cf-upgrade/.deps/cf_upgrade_test-update.Po: No such file or directory ``` Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The `init_script_test_helper` binary does not require any libraries. The libraries `libpromises.la` and `libtest.la` were previously added through the `LDADD` variable in the top of Makefile.am. Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
For some reason it causes the following error ``` 10:58:19 Makefile:598: ../../libpromises/.deps/lastseen.Po: No such file or directory 10:58:19 make[3]: *** No rule to make target '../../libpromises/.deps/lastseen.Po'. Stop. ``` in bootstrap_pr while doing `make dist` in Jenkins. Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
This reverts commit ba693ca.
Building stuff from libutils in test/unit causes make distclean to delete the same files twice resulting in failure. This happens as an effect of enabling subdir-objects which causes recursive builds. Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
We'll have to chose; either accepts deprecation warnings or upgrade bootstrap host |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.