ENT-10961, CFE-1840: Files promise can now modify immutable bit in file system attributes#5694
Closed
larsewi wants to merge 3 commits into
Closed
ENT-10961, CFE-1840: Files promise can now modify immutable bit in file system attributes#5694larsewi wants to merge 3 commits into
larsewi wants to merge 3 commits into
Conversation
|
Thanks for submitting a pull request! Maybe @craigcomstock can review this? |
larsewi
force-pushed
the
immutable
branch
3 times, most recently
from
c5e1a67 to
43ef275
Compare
larsewi
force-pushed
the
immutable
branch
4 times, most recently
from
3bfbc92 to
a3058d3
Compare
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
looks good! A few nitpicks.
larsewi
force-pushed
the
immutable
branch
5 times, most recently
from
3de1772 to
e33b4d3
Compare
larsewi
force-pushed
the
immutable
branch
6 times, most recently
from
2d128d0 to
bbbd1f7
Compare
Added syntax for `body fsattrs` with a boolean constraint `immutable`. It currently does nothing, but this will change in following commits. Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Ticket: ENT-10961, CFE-1840 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
immutable
branch
2 times, most recently
from
13802bc to
389becb
Compare
Ticket: ENT-10961, CFE-1840 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
Is superseded by #5752 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge together with NorthernTechHQ/libntech#235