CFE-4529: Added policy function getacls()

[larsewi]

• Added policy function to get ACLs
• Added acceptance test for getacls()

[larsewi]

@cf-bottom Jenkins please :)

[cf-bottom]

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/12308/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12308/

[nickanderson]

@larsewi I am a bit unsure about this error. Directories might not have acls on them, and rather than error, it sort of feels more correct to simply return an empty list. I want to say that getindcies and some other functions behave similarly to that.

This came up after the workshop when i was following up on a note to add example output to the documentation example.

root@hub:~# cf-agent -Kf ./t.cf 
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
R: Access acl: user::rw-
R: Access acl: group::r--
R: Access acl: other::r--
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
   error: Function getacls failed to get ACLs for '/etc': No data available
R: Default acl: $(default_acls)
root@hub:~# cat t.cf 
bundle agent __main__
{

  vars:

    "default_acls"
      slist => getacls("/etc", "default");

    "access_acls"
      slist => getacls("/tmp/bar", "access");

  reports:
    "Default acl: $(default_acls)";
    "Access acl: $(access_acls)";
}

[basvandervlies]

I was triggered by this update from @nickanderson and error is definitely not okl I assume we want the same as the getfacl command:

11:25 install3:~ $ getfacl /etc
getfacl: Removing leading '/' from absolute path names
# file: etc
# owner: root
# group: root
user::rwx
group::r-x
other::r-x

[larsewi]

Good catch 🚀 Fix here #5902