ENT-11988: Fixed bug where remote file copy always preserves source perms#5837
Merged
Conversation
Remote file copy with the 'copy_from' attribute now only preserves source file permissions if the 'preserve' attribute in 'body copy_from' is true. Otherwise it will use the permissions of the destination file if it already exists and default permissions if it does not. Ticket: ENT-11988 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
craigcomstock
approved these changes
Jul 15, 2025
olehermanse
approved these changes
Jul 15, 2025
Member
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12365/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12365/ |
Contributor
|
@cf-bottom jenkins please after fixing up the build host setup some more... |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12369/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12369/ |
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12393/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12393/ |
nickanderson
added
the
cherry-pick?
This was referenced Aug 19, 2025
Contributor
|
cherry-pick label removed, because I see that it cp-ed |
aleksandrychev
removed
the
cherry-pick?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote file copy with the 'copy_from' attribute now only preserves
source file permissions if the 'preserve' attribute in 'body copy_from'
is true. Otherwise it will use the permissions of the destination file
if it already exists and default permissions if it does not.
Ticket: ENT-11988
Changelog: Commit
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech
Back ported to: