CFE-4569: Fixed bug where files content promises skips remaining promises#5848
Merged
Conversation
Fixed a bug where a successful files content promise causes remaining files promise attribute handling to be skipped. Ticket: CFE-4569 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12442/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12442/ |
nickanderson
previously requested changes
Aug 1, 2025
nickanderson
left a comment
nickanderson
left a comment
Member
There was a problem hiding this comment.
Should we add a test case for using content this way?
Added acceptance test to test that fsattrs validation is not skipped when combining it with the content attribute. Ticket: CFE-4569 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12444/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12444/ |
olehermanse
approved these changes
Aug 4, 2025
craigcomstock
approved these changes
Aug 4, 2025
Contributor
|
looks like bootstrap-tests failed due to deb-11 system-testing instance not having enough disk space, from support tarball: so I wouldn't block merging this for that reason and I have added a ticket to check on this issue in our CI. ENT-13154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where a successful files content promise causes remaining
files promise attribute handling to be skipped.