CFE-4494: Fixed CIFS mounts on Linux#5859
Merged
Merged
Conversation
nickanderson
changed the title
larsewi
previously approved these changes
Aug 21, 2025
nickanderson
force-pushed
the
CFE-4494/master
branch
from
7b224a0 to
ae51e86
Compare
craigcomstock
previously approved these changes
Aug 22, 2025
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
a few comments, looks good!
larsewi
approved these changes
Aug 25, 2025
Contributor
|
Thanks 🚀 Please squash commits |
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
nice. you should probably squash a few commits in the middle around the logging.
…stab This commit introduces a conditional check to format the device string for CIFS and PanFS without a colon (:), as required by their specific syntax. It also updates the logging to show the full fstab entry that is being added. Additionally, the log message has been updated to be more descriptive, now displaying the full fstab entry that is being added. Ticket: CFE-4494
nickanderson
force-pushed
the
CFE-4494/master
branch
from
cd8bf1a to
4cc6527
Compare
Member
Author
|
@craigcomstock @larsewi squashed. |
Member
Author
|
@cf-bottom, jenkins please, :D :) :D |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12540/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12540/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-4494