Skip to content

ENT-4664: Added sys.policy_version#5873

Merged
larsewi merged 2 commits into
cfengine:masterfrom
victormlg:sys_policy_version
Oct 14, 2025
Merged

ENT-4664: Added sys.policy_version#5873
larsewi merged 2 commits into
cfengine:masterfrom
victormlg:sys_policy_version

Conversation

@victormlg

@victormlg victormlg commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Merge together:
cfengine/masterfiles#3050

@cf-bottom

Copy link
Copy Markdown

Thanks for submitting a PR! Maybe @craigcomstock can review this?

@victormlg victormlg marked this pull request as ready for review October 2, 2025 14:37
@victormlg

Copy link
Copy Markdown
Contributor Author

Build Status

@victormlg victormlg force-pushed the sys_policy_version branch 2 times, most recently from 387dcc6 to decce9b Compare October 2, 2025 15:39
@victormlg victormlg requested a review from larsewi October 2, 2025 15:39

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread libenv/sysinfo.c Outdated
Comment thread tests/acceptance/01_vars/01_basic/sys_policy_version.cf Outdated
Comment thread tests/acceptance/01_vars/01_basic/sys_policy_version.cf
@victormlg victormlg requested a review from larsewi October 6, 2025 08:20

@olehermanse olehermanse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because of a mistake in the masterfiles PR.

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good 🚀

Comment thread libenv/sysinfo.c
Ticket: ENT-4043
Changelog: Title
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
@victormlg victormlg requested a review from larsewi October 13, 2025 13:33
@larsewi

larsewi commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

@cf-bottom Jenkins please :)

@cf-bottom

Copy link
Copy Markdown

@craigcomstock

craigcomstock commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Test failures look known/flaky. One of them has a fix on the way...

@larsewi larsewi merged commit 02950aa into cfengine:master Oct 14, 2025
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants