Added helper scripts for platform package dependencies, build and install#5912
Merged
Merged
Conversation
craigcomstock
force-pushed
the
ENT-13016/master
branch
2 times, most recently
from
07b49a5 to
c345184
Compare
Contributor
Author
|
will see if I can make rockylinux/10 work here as well, then will put up for review. |
craigcomstock
force-pushed
the
ENT-13016/master
branch
from
c345184 to
a839eb1
Compare
larsewi
approved these changes
Oct 28, 2025
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Nice 🚀 Would be nice to have a comment in the top of the scripts briefly explaining what they do
| if [ -f /etc/os-release ]; then | ||
| source /etc/os-release | ||
| VERSION_MAJOR=${VERSION_ID%.*} | ||
| if [ "$ID" = "rhel" ] || [[ "$ID_LIKE" =~ "rhel" ]]; then |
Contributor
There was a problem hiding this comment.
No need to have double quotes around the string literals. But does not hurt
Comment on lines
+25
to
+26
| cd "$tmpdir" | ||
| git clone --recursive --depth 1 https://github.com/LMDB/lmdb |
Contributor
There was a problem hiding this comment.
Could consider using the -C option here
Suggested change
| cd "$tmpdir" | |
| git clone --recursive --depth 1 https://github.com/LMDB/lmdb | |
| git -C "$tmpdir" clone --recursive --depth 1 https://github.com/LMDB/lmdb |
Comment on lines
+27
to
+29
| cd lmdb/libraries/liblmdb | ||
| make | ||
| sudo make install prefix=/usr |
Contributor
There was a problem hiding this comment.
Would be nice to do this in a subshell, so that you don't have to cd back out
| @@ -0,0 +1,12 @@ | |||
| #!/usr/bin/env bash | |||
| set -ex | |||
| thisdir=$(dirname $0) | |||
Contributor
There was a problem hiding this comment.
Suggested change
| thisdir=$(dirname $0) | |
| thisdir="$(dirname "$0")" |
…tall For now this is focused on redhat-10-aarch64 and termux environment. Ticket: ENT-13016 Changelog: none
craigcomstock
force-pushed
the
ENT-13016/master
branch
from
a839eb1 to
a9842a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now this is focused on redhat-10-aarch64 and termux environment.
Ticket: ENT-13016
Changelog: none