CFE-4598: Added evaluation order in body file control

[victormlg]

Example:

body common control
{
  evaluation_order => "classic";
}

bundle agent __main__
{
# here the evaluation is "classic"
  methods:
    usebundle => A;
    usebundle => B;
}

bundle agent A
{
# here the evaluation is "classic"
}

body file control
{
  evaluation_order => "top_down";
}

bundle agent B
{
# here the evaluation is "top_down"
}

Merge together:
https://github.com/cfengine/enterprise/pull/869
https://github.com/cfengine/nova/pull/2485

[olehermanse]

@cf-bottom jenkins, please

[cf-bottom]

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/13032/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13032/

[larsewi]

13:50:19 license-checking.c:658:9: error: too few arguments to function ‘PolicyAppendBundle’
13:50:19          Bundle *bp = PolicyAppendBundle(track_license_policy, NamespaceDefault(), "track_license_bundle", "agent", NULL, NULL);
13:50:19          ^

Looks like you'll need some changes in nova and enterprise as well :)

[victormlg]

@cf-bottom jenkins, please

[cf-bottom]

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/13045/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13045/

[larsewi]

Should there be an else with parser error?

[victormlg]

Then the evaluation order stays as EVALUATION_ORDER_UNDEFINED. But the program will error on the wrong value later anyways, so wd don't really need to check for the right value here

[larsewi]

@olehermanse, @nickanderson wants to demo this on the agent is in. Can we merge this before release if the tests pass?

[larsewi]

The tests look good! @olehermanse, can we merge?

[olehermanse]

@larsewi yep