CFE-4605: Fixed getgroups test for AIX, solaris and suse 15#5950
Merged
Conversation
Contributor
|
|
Contributor
|
Solaris AIX |
victormlg
force-pushed
the
getgroups_bug
branch
from
ca59479 to
0e29c3a
Compare
Contributor
|
|
larsewi
approved these changes
Nov 26, 2025
Contributor
|
There was some conflicts. Can you squash the merge commit? |
craigcomstock
approved these changes
Nov 26, 2025
| nth(splitstring("$(this)", ":", 2), 0), "@(group_entries)" | ||
| ); | ||
| # slice out the 3 first entries: root, bin, daemon | ||
| # filter out root, bin, daemon |
Contributor
There was a problem hiding this comment.
Instead of filtering out... why don't you create the actual result dynamically by some shell scripting and compare that to the getgroups() output?
victormlg
changed the title
Ticket: CFE-4605 Changelog: Made the test for getgroups() more robust and fixed it for AIX and solaris Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
getgroups_bug
branch
from
1e515c2 to
8e51fb6
Compare
Contributor
|
@cf-bottom Jenkins with exotics please :) |
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/13126/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13126/ |
Contributor
Author
The error is not related |
craigcomstock
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.