Don't merge!#5951
Closed
larsewi wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
On HP-UX IA-64, mixing 32-bit (%d) and 64-bit (%jd/%ju) format specifiers in variadic arguments causes stack misalignment. In StatFile(), cf_makeholes, cf_ino, and cf_nlink were passed as uncast 32-bit integers among 64-bit arguments, causing all subsequent values (including cf_size) to be read from incorrect stack positions. This resulted in the client receiving a corrupted file size value (e.g., 212668465 instead of 821 bytes), triggering false "file corrupted in transit" errors during file copy operations. Fixed by casting cf_makeholes, cf_ino, and cf_nlink to (intmax_t) and changing their format specifiers from %d to %jd, ensuring consistent 64-bit alignment for all variadic arguments after the first parameter. Ticket: ENT-13508 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech