Skip to content

Change package_method promise behavior to only allow installing packages which are available #5978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
craigcomstock wants to merge 1 commit into from
Closed

Change package_method promise behavior to only allow installing packages which are available #5978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cf-agent/verify_packages.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2204,9 +2204,9 @@ static bool WillSchedulePackageOperation(EvalContext *ctx, const Attributes *a,
break;

default:
if (!matches) // why do we schedule a 'not matched' operation?
if (!matches)

@craigcomstock craigcomstock Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the package is a meta package? "yum install snmpd" would install net-snmpd so in that case this change would block an "snmpd" package_method promiser and I think that is OK. If we really wanted to we could amend the package_list_command to include the meta package names?

@craigcomstock craigcomstock Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here might be that we only don't want to schedule the operation if it is an Add. If the operation is a Verify we want to let it through to SchedulePackageOp().

{
return true;
Log(LOG_LEVEL_INFO, "Package '%s' is not an available package.", pp->promiser);
}
else if (!installed) // matches and not installed
{
Expand Down
Loading