ENT-13533: Fixed findlocalusers_unsafe test#5979
Merged
Merged
Conversation
Contributor
|
@cf-bottom Jenkins with exotics please :) |
|
Sure, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/13125/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13125/ |
victormlg
force-pushed
the
findlocalusers_unsafe
branch
2 times, most recently
from
b1c51c1 to
0f5c54a
Compare
craigcomstock
approved these changes
Dec 5, 2025
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
It looks like we needed to change the user names for some reason? I think this commit deserves some explanation of what was going wrong and how it was fixed.
larsewi
approved these changes
Dec 5, 2025
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Yes, would be nice with some explanation in the commit message as @craigcomstock points out
victormlg
force-pushed
the
findlocalusers_unsafe
branch
from
0f5c54a to
cc65046
Compare
Contributor
|
Only acceptance tests (with exotics): |
larsewi
requested changes
Dec 10, 2025
Contributor
There was a problem hiding this comment.
On AIX:
FAIL (UNEXPECTED FAILURE) ./01_vars/02_functions/unsafe/findlocalusers_unsafe.cf
---snip---
R: FILES DIFFER BUT SHOULD BE THE SAME
R: CONTENTS OF /home/jenkins/workspace/testing-pr/label/PACKAGES_ppc64_aix_71/cfengine-3.27.0a.7d3cbe96a/tests/acceptance/workdir/__01_vars_02_functions_unsafe_findlocalusers_unsafe_cf/tmp/TESTDIR.cfengine/actual:
{
"ulist1": [
"testu1"
],
"ulist2": [
"testu1"
],
"ulist3": [],
"ulist4": [],
"ulist5": [
"testu1",
"testu2"
],
"ulist6": [
"testu1"
],
"ulist7": [
"testu1"
],
"ulist8": {
}
}
R: CONTENTS OF /home/jenkins/workspace/testing-pr/label/PACKAGES_ppc64_aix_71/cfengine-3.27.0a.7d3cbe96a/tests/acceptance/./01_vars/02_functions/unsafe/findlocalusers_unsafe.cf.expected.json:
{
"ulist1": [
"testu1"
],
"ulist2": [
"testu1"
],
"ulist3": [
"testu1"
],
"ulist4": [
"testu1"
],
"ulist5": [
"testu1",
"testu2"
],
"ulist6": [
"testu1"
],
"ulist7": [
"testu1"
],
"ulist8": {
}
}
Changelog: Fixed the unsafe test for findlocalusers unsafe. Replaced the users in the test with custom ones, to make it depend less on the individual quirks of the OS. Changed the username of the custom users, because on AIX and HP-UX, it is limited by 8 characters. Ticket: ENT-13533 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
findlocalusers_unsafe
branch
from
cc65046 to
e242e90
Compare
Contributor
|
Only acceptance tests (with exotics): |
Contributor
Author
|
It looks like the failure are not related to the PR |
larsewi
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the unsafe test for findlocalusers unsafe. Replaced the users in the test with custom ones, to make it depend less on the individual quirks of the OS. Changed the username of the custom users, because on AIX and HP-UX, it is limited by 8 characters.