moved check for valid ipv4 as to not accept bogus address when matching /0 range#6015
Conversation
|
@cf-bottom Heyo, jenkins please? |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13314/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13314/ |
|
Thanks! Please add to the commit message. You can use |
5487343 to
10bca9d
Compare
olehermanse
left a comment
There was a problem hiding this comment.
@SimonThalvorsen The Ticket and Changelog parts Lars mentioned should be a kind of "footer", the commit should still have a good title (first line).
See here for more info and examples;
https://github.com/cfengine/core/blob/master/CONTRIBUTING.md
…hen matching /0 range Ticket: CFE-3081 Changelog: Fixed bug where isipinsubnet() fails to validate bogus IPv4 addresses when checking the 0.0.0.0/0 range
10bca9d to
ffd3ce4
Compare
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13320/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13320/ |
No description provided.