Skip to content

moved check for valid ipv4 as to not accept bogus address when matching /0 range#6015

Merged
larsewi merged 1 commit into
cfengine:masterfrom
SimonThalvorsen:CFE-3081
Jan 20, 2026
Merged

moved check for valid ipv4 as to not accept bogus address when matching /0 range#6015
larsewi merged 1 commit into
cfengine:masterfrom
SimonThalvorsen:CFE-3081

Conversation

@SimonThalvorsen

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Jan 14, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@SimonThalvorsen

Copy link
Copy Markdown
Contributor Author

@cf-bottom Heyo, jenkins please?

@cf-bottom

Copy link
Copy Markdown

@larsewi

larsewi commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Thanks! Please add

Ticket: CFE-3081
Changelog: Fixed bug where isipinsubnet() fails to validate bogus IPv4 addresses when checking the 0.0.0.0/0 range

to the commit message. You can use git commit --amend to modify the commit.

@olehermanse olehermanse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonThalvorsen The Ticket and Changelog parts Lars mentioned should be a kind of "footer", the commit should still have a good title (first line).

See here for more info and examples;
https://github.com/cfengine/core/blob/master/CONTRIBUTING.md

…hen matching /0 range

Ticket: CFE-3081
Changelog: Fixed bug where isipinsubnet() fails to validate bogus IPv4 addresses when checking the 0.0.0.0/0 range
@olehermanse

Copy link
Copy Markdown
Member

@cf-bottom jenkins, please

@cf-bottom

Copy link
Copy Markdown

@larsewi larsewi merged commit 2043064 into cfengine:master Jan 20, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants