CFE-4550: Added documentation for policy function findlocalgroups#3511
Conversation
|
Thank you for submitting a PR! Maybe @nickanderson can review this? |
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
I suggested clarifying that the data container is expected to be an array.
victormlg
force-pushed
the
findlocalgroups
branch
from
bf411ef to
5dfd553
Compare
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
Looks ok to me, dropped a comment showing how you can illustrate the json from policy.
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Please fix the formatting by running cfengine dev docs-format.
victormlg
force-pushed
the
findlocalgroups
branch
from
5dfd553 to
c72e9c2
Compare
|
The failing formatting checks are not related to my changes |
@victormlg you could have fixed them in a separate commit or a separate PR. Anyways, now they are fixed in master so just rebase. |
Ticket: CFE-4550 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
findlocalgroups
branch
from
c72e9c2 to
7915161
Compare
|
Core PR merged; cfengine/core#5882 |
|
@cf-bottom please build this in Jenkins :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/192/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-192/output/_site/ |
4 participants
No description provided.