Top down evaluation custom promise type test#3029
Merged
Merged
Conversation
nickanderson
previously requested changes
Aug 14, 2025
nickanderson
left a comment
nickanderson
left a comment
Member
There was a problem hiding this comment.
A couple small suggestions.
| { | ||
| inputs => { "../../default.cf.sub" }; | ||
| bundlesequence => { "test" }; | ||
| evaluation_order => "top_down"; |
victormlg
force-pushed
the
top-down-evaluation
branch
2 times, most recently
from
faf027e to
f6fab26
Compare
larsewi
approved these changes
Aug 18, 2025
Contributor
|
@victormlg looks like the test failed |
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
top-down-evaluation
branch
from
f6fab26 to
6e584a2
Compare
Contributor
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12523/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12523/ |
larsewi
dismissed
nickanderson’s stale review
Requested changes have been resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.