Fix form validation error message display when invalid => valid => in…#283
Open
chrishow wants to merge 1 commit into
Open
Fix form validation error message display when invalid => valid => in…#283chrishow wants to merge 1 commit into
chrishow wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…valid
Closes #274
Description
If there's a visible error, you fix it, and then introduce a new error without leaving the field, it will show the red "invalid" indicator without displaying the error message.
The error only shows again on-blur.
This PR fixes that bug.
Analysis
When you blur the field, the aria-invalid attribute is added.
Then when you fix the error, the aria-invalid attribute is removed.
If you then introduce a new error, the onInput handler returns before running isGroupValid/isFieldValid because the aria-invalid attribute isn't there.
This PR makes two changes:
Kelp Contributor License Agreement
I give Chris Ferdinandi and Go Make Things, LLC permission to license my contributions on any terms they like. I am giving them this license in order to make it possible for them to accept my contributions into their project.
As far as the law allows, my contributions come as is, without any warranty or condition, and I will not be liable to anyone for any damages related to this software or this license, under any kind of legal claim.