Fix Safari bug closing subnav without following link#284
Draft
chrishow wants to merge 1 commit into
Draft
Conversation
Author
|
I've left this as a draft PR because it increases the complexity of this component quite a lot. Perhaps someone has a better approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #282
Description
On Safari, clicking links inside the subnav closed the menu but prevented link navigation.
Safari's blur event sets
relatedTargettonullwhen clicking links, unlike Chrome which sets it to the clicked element.This meant the original
relatedTargetcheck couldn't determine that focus was moving to a link inside the nav, causing the subnav to close immediately without giving Safari a chance to follow the link.Changes
blurevent handler skips closing subnavs with thedata-navigatingflag via:not([data-navigating])selectorAdded mousedown and click event handlers to detect link clicks before blur events fire:
mousedown: Sets a temporarydata-navigatingflag on the details elementclick: Removes thedata-navigatingflag and closes the subnav after navigation startsKelp Contributor License Agreement
I give Chris Ferdinandi and Go Make Things, LLC permission to license my contributions on any terms they like. I am giving them this license in order to make it possible for them to accept my contributions into their project.
As far as the law allows, my contributions come as is, without any warranty or condition, and I will not be liable to anyone for any damages related to this software or this license, under any kind of legal claim.