fix: type-only LLM error messages to stop 200-path leakage#478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
LocalLLMClient/GrokClient/ClaudeClienton_otherhandlers previously setmessage=f"... {str(e)}". That string flows throughgraph._generate_or_errorinto the HTTP 200QueryResponse.answer/errorfields withoutgate._sanitize_error(only the bare 500 path sanitizes).Now:
on_othermessages are type-only (LM Studio error: ValueError) withdetails.exc_type_extract_content/_extract_claude_contentValueErrors no longer append exception text or content reprs that can echo proxy HTML / body fragmentsWhy / benefit
Stops accidental disclosure of URLs, body fragments, and credential-shaped strings in successful-status answers when generation fails. Root cause fixed once in the client (all three providers).
Risk to monitor
Operators lose the free-form exception message in the answer UI; type + logs still diagnose. Audit still gets
code: messagewith the type-only message.Verify
GROK_API_KEY=dummy pytest tests/test_client.py tests/test_graph.py tests/test_runtime_errors.py -q— all passed.Scan context
CyClaw-Optimize continuation (ponytail + Karpathy + python-coding-agent). Companion to #477 (sanitizer FPs).