Add a country field for people and localize the calendar to the active language#2034
Merged
Conversation
Expose a reactive localeCode (a valid Intl/moment code such as 'en' or 'zh-tw') updated by setLocale, so consumers re-localize when the language changes.
Drive FullCalendar's locale from the reactive localeCode and refresh it on language change, instead of being hardcoded to English.
Editable in the person modal and shown as a column in the people list, localized with Intl.DisplayNames from the ISO 3166-1 alpha-2 codes. The country is only stored for non-bot, non-client people.
Add the country field to the profile page (hidden for clients and guests), reusing the people country combobox options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
PR linked to cgwire/zou#1100