[players] Tighten panzoom and add scrub/focus shortcuts#2035
Merged
Conversation
When the comparison viewer's revision was swapped, its panzoom was rebuilt at identity but the panzoomTransform watcher only fires on value changes — so a fresh comparison instance stayed at (0,0,1) while the main viewer kept its zoom, and the two drifted apart. Have VideoViewer / PictureViewer emit panzoom-ready after each setup (PreviewViewer forwards it), and push the main viewer's current transform onto the comparison from PreviewPlayer's handler. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
triggered by clicks in the area around the media, and stole the player's
keyboard shortcuts.
(Preview Player on Main Page doesn't use browser scaling for the videoplayer #1541).
swipe and dropped unsaved comments (Dragging on timeline with touch / pen causes Chrome to navigate backward or forward #1700).
Solutions
beforeMouseDown/beforeWheelguards, and setdisableKeyboardInteraction: true.viewer's edge.
loadedmetadataand reset it oncebound.
defaultHeightfrom reactivewindow.innerWidth / innerHeight.with the comment textarea; nested players let the innermost handle the
event.
overscroll-behavior-x: containon player + timeline,touch-action: pan-yon progress bars.