Fix double-mean bug in climatology when detrend='none'#23
Open
loganchal wants to merge 1 commit intochadagreene:masterfrom
Open
Fix double-mean bug in climatology when detrend='none'#23loganchal wants to merge 1 commit intochadagreene:masterfrom
loganchal wants to merge 1 commit intochadagreene:masterfrom
Conversation
When running climatology with ('detrend','none'), the mean of the data is added to the output twice. The 'none' option skips the initial detrending step, so the mean remains inside Ac. Then meanAr is added back unconditionally at the end, doubling it.
Fix: extend the conditional to also exclude the 'none' case.
On the buggy code this reproducer will return all 20s for a string of constant 10s before the fix:
t = datenum(2000,1,1):datenum(2000,12,31);
data = ones(size(t)) * 10;
clim = climatology(data, t, 'daily', 'detrend', 'none');
mean(clim) % returns 20 instead of 10 before fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running climatology with ('detrend','none'), the mean of the data is added to the output twice. The 'none' option skips the initial detrending step, so the mean remains inside Ac. Then meanAr is added back unconditionally at the end, doubling it.
Fix: extend the conditional to also exclude the 'none' case.
On the buggy code this reproducer will return all 20s for a string of constant 10s before the fix: