Skip to content

setup-knative: Fix bug in version=="latest" case #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jku wants to merge 1 commit into
base: main
Choose a base branch
from
Open

setup-knative: Fix bug in version=="latest" case #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup-knative/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ runs:
elif [ "${REPO}" == "eventing" -a "${{ inputs.eventing-version }}" != "" ]; then
REAL_KNATIVE_VERSION="knative-v${{ inputs.eventing-version }}"
elif [ ${{ inputs.version }} == "latest" ]; then
REAL_KNATIVE_VERSION=$(git ls-remote --tags --refs https://github.com/knative/${REPO} | awk '{print $2}' | sed 's/refs\/tags\/.*v//g' | sort -V | tail -1)
VERSION=$(git ls-remote --tags --refs https://github.com/knative/${REPO} | awk '{print $2}' | sed 's/refs\/tags\/.*v//g' | sort -V | tail -1)
REAL_KNATIVE_VERSION="knative-v${VERSION}"
# It will match only if the input is something like `1.2.x` if there is any trailing chars (`1.2.xa`) that will not match
elif [[ ${{ inputs.version }} == *".x" ]]; then
INPUT=$(echo ${{ inputs.version }} | sed 's/.x//g')
Expand Down
Loading