Skip to content

feat(policy): allow arguments with comma character#2306

Merged
Piskoo merged 1 commit into
chainloop-dev:mainfrom
Piskoo:feat-policy-allow-arguments-with-commma-character
Aug 5, 2025
Merged

feat(policy): allow arguments with comma character#2306
Piskoo merged 1 commit into
chainloop-dev:mainfrom
Piskoo:feat-policy-allow-arguments-with-commma-character

Conversation

@Piskoo

@Piskoo Piskoo commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

This PR adds a way to escape , character with \ in policy arguments.

Closes #1979

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo Piskoo marked this pull request as ready for review August 5, 2025 07:18
@Piskoo Piskoo requested review from javirln, jiparis and migmartri August 5, 2025 07:18
@migmartri

Copy link
Copy Markdown
Member

thanks @Piskoo, in which cases do we need scaped commas?

@Piskoo

Piskoo commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

thanks @Piskoo, in which cases do we need scaped commas?

There might be a specific case where commas are included in the value fields in materials, but I'm not confident what the exact use case was @jiparis.

@jiparis

jiparis commented Aug 5, 2025

Copy link
Copy Markdown
Member

We don't have any case in our builtin policies, but this might be useful for custom policies.

@Piskoo Piskoo merged commit c9f809f into chainloop-dev:main Aug 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow policy arguments with comma character

3 participants