Skip to content

fix(workflow): deleting the only workflow in the project deletes the project #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Piskoo merged 1 commit into from
Aug 8, 2025
Merged

fix(workflow): deleting the only workflow in the project deletes the project #2318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions app/controlplane/pkg/data/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,21 +406,11 @@ func (r *WorkflowRepo) SoftDelete(ctx context.Context, id uuid.UUID) (err error)
}

// Soft delete workflow
wf, err := tx.Workflow.UpdateOneID(id).SetDeletedAt(time.Now()).SetUpdatedAt(time.Now()).Save(ctx)
_, err := tx.Workflow.UpdateOneID(id).SetDeletedAt(time.Now()).SetUpdatedAt(time.Now()).Save(ctx)
if err != nil {
return err
}

// Soft delete project if it has no more workflows
// TODO: in the future, we'll handle this separately through explicit user action
if wfTotal, err := wf.QueryProject().QueryWorkflows().Where(workflow.DeletedAtIsNil()).Count(ctx); err != nil {
return err
} else if wfTotal == 0 {
// soft deleted project if it has no more workflows
if err := tx.Project.UpdateOneID(wf.ProjectID).SetDeletedAt(time.Now()).Exec(ctx); err != nil {
return err
}
}
return nil
})
}
Expand Down
Loading