feat(policy): allow empty kind in policy#2343
Closed
Piskoo wants to merge 5 commits into
Closed
Conversation
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
migmartri
reviewed
Aug 11, 2025
migmartri
left a comment
migmartri
left a comment
Member
There was a problem hiding this comment.
How does this behave when the policies have kinds? does it override it?
Member
|
Can you rebase main please? I just merged your other change to run some tests |
migmartri
approved these changes
Aug 11, 2025
migmartri
left a comment
migmartri
left a comment
Member
There was a problem hiding this comment.
just checked this and it seems to work as expected
jiparis
approved these changes
Aug 11, 2025
Co-authored-by: Miguel Martinez Trivino <migmartri@gmail.com> Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds material selector handler to policy devel eval. If no kind was specified in the policy then the policy will always be applied to the given material.
Closes #2337