Skip to content

feat(policy-devel): drop support for yaml and embedded rego formatting#2383

Merged
Piskoo merged 2 commits into
chainloop-dev:mainfrom
Piskoo:feat-policy-devel-drop-support-for-yaml-format
Aug 21, 2025
Merged

feat(policy-devel): drop support for yaml and embedded rego formatting#2383
Piskoo merged 2 commits into
chainloop-dev:mainfrom
Piskoo:feat-policy-devel-drop-support-for-yaml-format

Conversation

@Piskoo

@Piskoo Piskoo commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

This PR removes support for yaml and embedded rego formatting due issues caused by yaml libraries limitations.

Closes #2379

Piskoo added 2 commits August 21, 2025 14:49
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
@Piskoo Piskoo marked this pull request as ready for review August 21, 2025 13:08
@Piskoo Piskoo requested review from javirln and migmartri August 21, 2025 13:08
@Piskoo Piskoo merged commit 6ae620d into chainloop-dev:main Aug 21, 2025
13 checks passed
@migmartri

Copy link
Copy Markdown
Member

@Piskoo do we still check that the policy is a valid policy spec? Meaning that we can marshal it?

@Piskoo

Piskoo commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

@migmartri Only for eval, the only operation that lint does on yaml files is lookup for rego script paths

@migmartri

Copy link
Copy Markdown
Member

@migmartri Only for eval, the only operation that lint does on yaml files is lookup for rego script paths

there might be value on still checking that it's a valid policy spec no? Before we used to run even proto validations on the spec no?

@Piskoo

Piskoo commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

@migmartri Only for eval, the only operation that lint does on yaml files is lookup for rego script paths

there might be value on still checking that it's a valid policy spec no? Before we used to run even proto validations on the spec no?

Correct, took a look and validations are still ran on policy spec but errors are ignored. I'll fix it in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chainloop policy devel lint --format should not reformat multi-line YAML descriptions

2 participants